Skip to content

Commit

Permalink
output/cloud: Hide the versioning feat flag
Browse files Browse the repository at this point in the history
  • Loading branch information
codebien committed Jun 7, 2023
1 parent 3ab0085 commit 0a31512
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
7 changes: 6 additions & 1 deletion cloudapi/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,12 @@ type Config struct {
TestRunDetails null.String `json:"testRunDetails" envconfig:"K6_CLOUD_TEST_RUN_DETAILS"`
NoCompress null.Bool `json:"noCompress" envconfig:"K6_CLOUD_NO_COMPRESS"`
StopOnError null.Bool `json:"stopOnError" envconfig:"K6_CLOUD_STOP_ON_ERROR"`
APIVersion null.Int `json:"apiVersion" envconfig:"K6_CLOUD_API_VERSION"`

// TODO: Renable the cloud output versioning
// https://github.com/grafana/k6/issues/3117
//
// APIVersion null.Int `json:"apiVersion" envconfig:"K6_CLOUD_API_VERSION"`
APIVersion null.Int `json:"-"`

MaxMetricSamplesPerPackage null.Int `json:"maxMetricSamplesPerPackage" envconfig:"K6_CLOUD_MAX_METRIC_SAMPLES_PER_PACKAGE"`

Expand Down
4 changes: 4 additions & 0 deletions output/cloud/output_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,10 @@ func TestOutputCreateTestWithConfigOverwrite(t *testing.T) {
}

func TestOutputStartVersionError(t *testing.T) {
t.Skip("We disabled the Versioning to prevent mistakes and not be forced to " +
"maintain an experimental API in the future. " +
"We will re-enable it after the v0.45.0 release.")

t.Parallel()
o, err := newOutput(output.Params{
Logger: testutils.NewLogger(t),
Expand Down

0 comments on commit 0a31512

Please sign in to comment.