Merge pull request #3271 from grafana/add-interfacebloat-linter

Add interfacebloat linter

.golangci.yml

@@ -96,6 +96,7 @@ linters:
     - govet
     - importas
     - ineffassign
+    - interfacebloat
     - lll
     - makezero
     - misspell

lib/executors.go

@@ -55,6 +55,8 @@ type ExecutionStep struct {
 // TODO: make []ExecutionStep or []ExecutorConfig their own type?
 
 // ExecutorConfig is an interface that should be implemented by all executor config types
+//
+//nolint:interfacebloat // We don't have plan to split it.
 type ExecutorConfig interface {
 	Validate() []error
 

lib/runner.go

@@ -46,6 +46,11 @@ type VUActivationParams struct {
 //
 // TODO: Rename this to something more obvious? This name made sense a very long
 // time ago.
+//
+// interfacebloat: We may evaluate in the future to move out some methods;
+// but considering how central it is, it would require a huge effort.
+//
+//nolint:interfacebloat
 type Runner interface {
 	// Creates an Archive of the runner. There should be a corresponding NewFromArchive() function
 	// that will restore the runner from the archive.