Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove magic resolution of modules imports from CDNJS/GitHub #1408

Open
2 tasks
imiric opened this issue Apr 24, 2020 · 2 comments
Open
2 tasks

Remove magic resolution of modules imports from CDNJS/GitHub #1408

imiric opened this issue Apr 24, 2020 · 2 comments
Assignees
Labels
breaking change for PRs that need to be mentioned in the breaking changes section of the release notes

Comments

@imiric
Copy link
Contributor

imiric commented Apr 24, 2020

We've seen intermittent failures of TestCDNJS because their API sometimes returns empty results (files is empty). Right now you can see this if you request https://api.cdnjs.com/libraries/Faker a few times.

To avoid test failures we should skip this test for now, but this issue can also serve as a starting point for discussing eventually removing the "magic" URL loading from CDNJS or maybe even GitHub, to avoid confusing users (e.g. grafana/k6-docs#8).

Tasks

@imiric imiric added the evaluation needed proposal needs to be validated or tested before fully implementing it in k6 label Apr 24, 2020
imiric pushed a commit that referenced this issue Apr 24, 2020
@imiric imiric mentioned this issue Apr 24, 2020
imiric pushed a commit that referenced this issue Apr 24, 2020
@mstoykov
Copy link
Collaborator

as I mentioned in the internal discussion, I am for disabling both github and cdnjs magic urls and the schemeless remote ones as well, but add a flag to enable them (I would argue we don't need separate flags). Have it this way for ... a year and drop them altogether.
Obviously we will need to also remove them from the documentation and make certain all our *-to-k6 tools generate only scripts not using both.
We will probably also have some logic that if you run an archive created from before the version we release that the flag is ON instead of OFF but we still print a warning ...

imiric pushed a commit that referenced this issue Apr 24, 2020
imiric pushed a commit that referenced this issue Apr 24, 2020
@mstoykov mstoykov changed the title Consider dropping support for CDNJS loader Remove magic resolution of modules imports from CDNJS/GitHub Mar 27, 2024
@mstoykov
Copy link
Collaborator

I have update the issue to reflect the current consensus of going forward with removing this magical resolution.

For v0.51.0 we will be adding a warning. Anc currently plan to drop it in 0.53.0

@mstoykov mstoykov added breaking change for PRs that need to be mentioned in the breaking changes section of the release notes and removed evaluation needed proposal needs to be validated or tested before fully implementing it in k6 labels Mar 27, 2024
@mstoykov mstoykov self-assigned this Apr 1, 2024
mstoykov added a commit that referenced this issue Apr 2, 2024
Part of #1408

Co-authored-by: Oleg Bespalov <oleg.bespalov@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change for PRs that need to be mentioned in the breaking changes section of the release notes
Projects
None yet
Development

No branches or pull requests

2 participants