-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove magic resolution of modules imports from CDNJS/GitHub #1408
Comments
as I mentioned in the internal discussion, I am for disabling both github and cdnjs magic urls and the schemeless remote ones as well, but add a flag to enable them (I would argue we don't need separate flags). Have it this way for ... a year and drop them altogether. |
I have update the issue to reflect the current consensus of going forward with removing this magical resolution. For v0.51.0 we will be adding a warning. Anc currently plan to drop it in 0.53.0 |
Part of #1408 Co-authored-by: Oleg Bespalov <oleg.bespalov@grafana.com>
We've seen intermittent failures of
TestCDNJS
because their API sometimes returns empty results (files
is empty). Right now you can see this if you request https://api.cdnjs.com/libraries/Faker a few times.To avoid test failures we should skip this test for now, but this issue can also serve as a starting point for discussing eventually removing the "magic" URL loading from CDNJS or maybe even GitHub, to avoid confusing users (e.g. grafana/k6-docs#8).
Tasks
The text was updated successfully, but these errors were encountered: