Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k6 doesn't display all cloud test run statuses as expected #1488

Closed
mpandurovic opened this issue Jun 5, 2020 · 4 comments
Closed

k6 doesn't display all cloud test run statuses as expected #1488

mpandurovic opened this issue Jun 5, 2020 · 4 comments
Assignees
Milestone

Comments

@mpandurovic
Copy link

Expected Behavior

Screenshot from 2020-06-05 14-06-54

k6 should display cloud statuses according to response received from /test-progress/ID endpoint. This works as expected in 0.26.

Actual Behavior

Screenshot from 2020-06-05 14-07-36

Test run statuses like INITIALIZING and QUEUED are skipped and progress bar shows Run ... throughout several stages of test run's setup in cloud.

Steps to Reproduce the Problem

  1. Run new-executors build with k6 cloud.
@na-- na-- added this to the v0.27.0 milestone Jun 5, 2020
@imiric imiric self-assigned this Jun 8, 2020
imiric pushed a commit that referenced this issue Jun 8, 2020
imiric pushed a commit that referenced this issue Jun 9, 2020
imiric pushed a commit that referenced this issue Jun 16, 2020
@na--
Copy link
Member

na-- commented Jun 16, 2020

@imiric, just noticed a somewhat connected issue, while fixing something else - in cmd/run.go, the right text in the printBar() invocations is very obtuse, such print calls are very rarely called, the initBar.Modify(pb.WithConstProgress(0, "<some-text>")) calls seem to be completely ignored... Not urgent, but we'll have to revisit how and what we print in all of these progressbars before v0.27.0 comes out...

@imiric
Copy link
Contributor

imiric commented Jun 16, 2020

@na-- Hhmm yeah, the right side text set in the progress bar is ignored by printBar(), and we're not calling it everywhere it should be. I'll look into it.

imiric pushed a commit that referenced this issue Jun 16, 2020
@imiric
Copy link
Contributor

imiric commented Jun 16, 2020

@na-- Let me know if 6df9b4b is what you had in mind. I opted for removing the rightText arg from printBar(), which is not as convenient as before, but it forces the use of the PB API, so I think it's cleaner.

There's still some inconsistencies between run and cloud (and a few TODOs), but the rendering should be better aligned now.

imiric pushed a commit that referenced this issue Jul 6, 2020
imiric pushed a commit that referenced this issue Jul 6, 2020
@imiric
Copy link
Contributor

imiric commented Jul 6, 2020

Closed by #1490.

@mpandurovic Let us know if it works better now. :)

@imiric imiric closed this as completed Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants