Implement more of the jQuery API

[ragnarlonn]

Manipulation API

• attr() [readonly]
• html() [readonly]
• prop() [readonly]
• text() [readonly]
• val() [readonly]

Traversal API

• add()
• children()
• closest()
• contents()
• each()
• end()
• eq()
• filter()
• find()
• first()
• has()
• is()
• last()
• map()
• next()
• nextAll()
• nextUntil()
• not()
• parent()
• parents()
• parentsUntil()
• prev()
• prevAll()
• prevUntil()
• siblings()
• slice()

Misc API

• get()
• toArray()
• index()
• data() [readonly]

Imported from https://trello.com/c/1XvRjs9A/89-implement-more-of-the-jquery-api

[ragnarlonn]

Emily Ekberg
If someone else wanted to do this, I wouldn't mind pointing out how to, it's mostly a whole lot of writing bridge code. The time-consuming part is writing unit tests for every call.
Nov 2 at 2:45 PM - Reply - Delete

[liclac]

Fairly low-hanging fruit if someone else wants to take this. Just look at the existing bridges and add more like them.

[ppcano]

@uppfinnarn Help wanted label?

[liclac]

@ppcano Yes, please. Though it'll have to wait until the new JS runner is merged, which will make this all even easier to do.

[micsjo]

val() is not implemented in goquery. attr() is as well as attrOr(). I suggest implementing at least attr().

[denim2x]

@ragnarlonn I'd like to finish this task; is the bounty still available ?

[robingustafsson]

@denim2x Yes, the bounty is still available. No one else has started working on this issue afaik, so go for it!

[robingustafsson]

@denim2x To clarify, this issue should be implemented in terms of the js2 runner (https://github.com/loadimpact/k6/tree/master/js2). So extending what's in https://github.com/loadimpact/k6/blob/master/js2/modules/k6/html/html.go more or less.

Edit: and running k6 with the js2 runner is done by executing k6 run -t js2 my_script.js

[denim2x]

@robingustafsson Thanks

[denim2x]

@robingustafsson question: What is the expected behavior of prop():

• hash map storage
• empty string
• nil
• other?

[liclac]

Could you elaborate?

[denim2x]

prop(name) is supposed to return the property name and there's no implementation in goquery for this - so how should it behave?

[liclac]

Ah, I see. Just leave it out then - I believe the attr()/prop() split was in a more recent jQuery version.

[denim2x]

• do methods like children have to support filtering?
• if so - are Matchers also required?

[liclac]

I'd say yes, we want to get as close to the original jQuery API as possible; goja.AssertFunction is your friend, that gives you a function you can call as fn(this goja.Value, args ...goja.Value) goja.Value.

[ragnarlonn]

@denim2x Hi Cristian, are you making any progress? Is anything still unclear?

[catesq]

Hello. On bountysource they changed status to stopped working on it so it seemed like it'd be ok for me to step in...

I've made a fork and a start in feature/jquery branch. Have only added Html() and a basic implementation of Val() so far.

Would you like a PR with what I've got now?

[ragnarlonn]

@mitnuh Yeah, I think a PR is probably good. If @liclac can take a look at it now and give feedback it might save you some time spent changing things later.

[catesq]

Hi. Sorry to bother you but is it ok to close this issue? The PR has been merged but the bounty can't be claimed until the related issue is closed. Thank you.

[robingustafsson]

@mitnuh Yes, I'll close the issue. Thank you for your hard work!

[catesq]

Thank you!