Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabled tests under windows #902

Open
mstoykov opened this issue Jan 21, 2019 · 3 comments
Open

Fix disabled tests under windows #902

mstoykov opened this issue Jan 21, 2019 · 3 comments

Comments

@mstoykov
Copy link
Collaborator

Currently being skipped under windows in appveyor.

@na-- na-- changed the title Fix tracer tests under windows Fix disabled tests under windows Mar 20, 2019
@na-- na-- added the tests label Mar 20, 2019
@na--
Copy link
Member

na-- commented Mar 20, 2019

Maybe this won't be a problem after #959, since the Azure machines may be more powerful than the AppVeyor ones...

In any case, I disabled another test under Windows...

Currently, the list of disabled tests under Windows is:

Some of those tests could be fixed by relaxing the time constraints a bit, or in the case of the last one, by splitting up the test into multiple smaller tests...

@ahmedalhulaibi
Copy link

I was just looking through this and a lot has changed. Here's an updated list of disabled test under Windows that I found:

@codebien
Copy link
Collaborator

codebien commented Nov 2, 2023

An updated list

t.Run("ocsp_stapled_good", func(t *testing.T) {
t.Parallel()
if runtime.GOOS == "windows" {
t.Skip("this doesn't work on windows for some reason")
}

func TestConstantArrivalRateRunCorrectTiming(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skipf("this test is very flaky on the Windows GitHub Action runners...")
}

func TestMakeRequestDialTimeout(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skipf("dial timeout doesn't get returned on windows") // or we don't match it correctly
}

Relevant related issue #903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants