Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependencies for the API that are not necessary #911

Closed
mstoykov opened this issue Jan 29, 2019 · 0 comments · Fixed by #2313
Closed

Remove dependencies for the API that are not necessary #911

mstoykov opened this issue Jan 29, 2019 · 0 comments · Fixed by #2313
Assignees
@olegbespalov
Labels
good first issue maintenance refactor
Milestone
v0.37.0

Comments

@mstoykov
Copy link
Collaborator

This probably should be done when we rewrite for #550.
Removing the api directory and then removing dependencies through dep ensure removed 3mb from vendor. And we definitely don't need negroni or api2go for 5 api calls
@mstoykov mstoykov changed the title Remove api dependancies that are not necessary Remove dependancies for the api that are not necessary Jan 29, 2019
@mstoykov mstoykov changed the title Remove dependancies for the api that are not necessary Remove dependancies for the API that are not necessary Jan 29, 2019
@mstoykov mstoykov mentioned this issue Apr 9, 2019
Closed
@mstoykov mstoykov mentioned this issue Oct 21, 2019
Merged
@na-- na-- removed the lower prio label Mar 25, 2020
mstoykov added a commit that referenced this issue Apr 2, 2021
@mstoykov
Drop github.com/urfave/negroni as a dependency
f84bb8b 
The only "breaking change" is that if now k6 panics during answering a
REST API request it will close the connection instead of returning
`500`. This can also be done easily I just don't think it's particularly
necessary.

This is part of #911
@mstoykov mstoykov mentioned this issue Apr 2, 2021
Merged
@na-- na-- changed the title Remove dependancies for the API that are not necessary Remove dependencies for the API that are not necessary Apr 6, 2021
@olegbespalov olegbespalov self-assigned this Dec 15, 2021
olegbespalov added a commit that referenced this issue Dec 17, 2021
@olegbespalov
refactor(#911): move the JSON API structs to the separated files
74fb521
olegbespalov added a commit that referenced this issue Dec 17, 2021
@olegbespalov
refactor(#911): implement JSON API for the setup
55fb1ac
olegbespalov added a commit that referenced this issue Dec 17, 2021
@olegbespalov
refactor(#911): adjust the client, remove the api2go package
f08aa8f
@olegbespalov olegbespalov mentioned this issue Dec 20, 2021
Merged
@olegbespalov olegbespalov mentioned this issue Dec 28, 2021
Merged
@na-- na-- added this to the v0.37.0 milestone Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olegbespalov olegbespalov

Labels
good first issue maintenance refactor
Projects
None yet
Milestone
v0.37.0
Development

Successfully merging a pull request may close this issue.

refactor: removal of the manyminds/api2go, part 2 grafana/k6
3 participants
@mstoykov @na-- @olegbespalov