Upgrade envconfig #1214
Merged
Upgrade envconfig #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removing configdir is done in #1211 |
|
@cuonglm Ah, thanks, will remove it from here then. I saw your |
We were using a very old version (Jan 2017), and the new one includes fixes like kelseyhightower/envconfig#119 , which would avoid workarounds in PRs like #1143.
imiric
force-pushed
the
chore/bump-envconfig
branch
from
c5df4dd
to
a1f50e4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1214 +/- ##
==========================================
- Coverage 73.65% 73.63% -0.02%
==========================================
Files 147 147
Lines 10641 10641
==========================================
- Hits 7838 7836 -2
- Misses 2344 2345 +1
- Partials 459 460 +1
Continue to review full report at Codecov.
|
na--
approved these changes
Oct 24, 2019
mstoykov
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using a very old version (Jan 2017), and the new one includes fixes like kelseyhightower/envconfig#119 , which would avoid workarounds in PRs like #1143.