Make some executor tests more deterministic #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 25, 2020 11:39
This doesn't get rid of the flakiness entirely, but merely shifts things around and uses safer timings to reduce the possibility of failures. In my tests the behavior is much more stable now, though there are still issues on Windows during quick CPU usage bursts, which I'm hopeful we won't run into on GH Actions.
This doesn't get rid of the flakiness entirely, but merely shifts things around and uses safer timings to reduce the possibility of failures. In my tests the behavior is much more stable now, though there are still issues on Windows during quick CPU usage bursts, which I'm hopeful we won't run into on GH Actions.
This does the same functional check as before in a simpler way, while also ensuring all values were covered, whereas in the previous version a sequence of repeating values that doesn't decrement would erroneously pass the test.
mstoykov
approved these changes
Mar 25, 2020
na--
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors a couple of tests mentioned in #1357 to reduce their chances of failure. :) It doesn't get rid of the flakiness entirely, but merely shifts things around and uses safer timings. In my tests the behavior is much more stable now, though there could still be some failures on Windows during quick CPU usage bursts, which I'm hopeful we won't run into on GH Actions.
After these changes stress testing both for about an hour didn't produce failures on Linux nor Windows:
Whereas on
new-schedulersboth tests fail quickly:It's likely these might be more susceptible to failure when run as part of the entire package instead of individually, and while I didn't see them fail when stress testing
lib/executor, I did see others mentioned here, some of which I'll take a look at next.Moving forward, it might be a good idea to setup stress testing of certain packages as a periodic CI task so we can catch the flakiness sooner.