Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metrics processing after test run #1460

Merged
merged 2 commits into from
May 22, 2020

Conversation

na--
Copy link
Member

@na-- na-- commented May 21, 2020

This is a quick and dirty fix for #1434, though as I mention in that issue, the proper solution would be rewriting that code from scratch...

@na--
Copy link
Member Author

na-- commented May 21, 2020

Maaybe I should have ran the tests before pushing a PR... 🤦‍♂️

This is a quick and dirty fix for #1434, though as I mention in that issue, the proper solution would be rewriting that code from scratch...
@na-- na-- force-pushed the fix-metrics-processing-after-run branch from 212111a to 33ae252 Compare May 21, 2020 14:12
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020

Codecov Report

Merging #1460 into new-schedulers will increase coverage by 0.00%.
The diff coverage is 94.11%.

Impacted file tree graph

@@               Coverage Diff               @@
##           new-schedulers    #1460   +/-   ##
===============================================
  Coverage           76.69%   76.70%           
===============================================
  Files                 163      163           
  Lines               12986    12996   +10     
===============================================
+ Hits                 9960     9968    +8     
- Misses               2515     2517    +2     
  Partials              511      511           
Impacted Files Coverage Δ
cmd/run.go 9.28% <0.00%> (ø)
core/engine.go 88.73% <100.00%> (+0.53%) ⬆️
lib/executor/variable_looping_vus.go 94.46% <0.00%> (-0.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0ddf5d...c675aa9. Read the comment docs.

Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though there's still the minor UI issue when run with -v that the Waiting for engine processes to finish and later log lines appear after the EOT summary is printed, which is a bit unsightly, but not a big deal.

core/engine.go Outdated Show resolved Hide resolved
@na--
Copy link
Member Author

na-- commented May 22, 2020

LGTM, though there's still the minor UI issue when run with -v that the Waiting for engine processes to finish and later log lines appear after the EOT summary is printed, which is a bit unsightly, but not a big deal.

Nothing we can do about that unfortunately... These events simply occur after the end-of-test summary has been printed.

Co-authored-by: Ivan Mirić <ivan@loadimpact.com>
@na-- na-- merged commit d3a1546 into new-schedulers May 22, 2020
@na-- na-- deleted the fix-metrics-processing-after-run branch May 22, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants