-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix metrics processing after test run #1460
Conversation
Maaybe I should have ran the tests before pushing a PR... 🤦♂️ |
This is a quick and dirty fix for #1434, though as I mention in that issue, the proper solution would be rewriting that code from scratch...
212111a
to
33ae252
Compare
Codecov Report
@@ Coverage Diff @@
## new-schedulers #1460 +/- ##
===============================================
Coverage 76.69% 76.70%
===============================================
Files 163 163
Lines 12986 12996 +10
===============================================
+ Hits 9960 9968 +8
- Misses 2515 2517 +2
Partials 511 511
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though there's still the minor UI issue when run with -v
that the Waiting for engine processes to finish
and later log lines appear after the EOT summary is printed, which is a bit unsightly, but not a big deal.
Nothing we can do about that unfortunately... These events simply occur after the end-of-test summary has been printed. |
Co-authored-by: Ivan Mirić <ivan@loadimpact.com>
This is a quick and dirty fix for #1434, though as I mention in that issue, the proper solution would be rewriting that code from scratch...