-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: format import statement #1464
Conversation
have the follow error:
|
I only change order: https://github.com/loadimpact/k6/pull/1464/files#diff-f2ba53414ba64f2e71d42ad483572e4cR29 but have the follow error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have a typo, loadimpack
should be loadimpact
...
@na-- oh...fixed, thanks! |
Codecov Report
@@ Coverage Diff @@
## new-schedulers #1464 +/- ##
==================================================
- Coverage 76.74% 76.71% -0.04%
==================================================
Files 163 163
Lines 12996 12996
==================================================
- Hits 9974 9970 -4
- Misses 2511 2515 +4
Partials 511 511
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rice-box.go
files are go:generate
d files, so you shouldn't change them manually. Please revert those, the other changes seem fine.
@na-- thanks! suggest to add |
Feel free to use this PR to rename them (and adjust the |
OK, I will reopen one pr to solve it -- |
first part: the standard package
second part: third package
third part: k6 package