Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: format import statement #1464

Merged
merged 10 commits into from
May 27, 2020
Merged

chore: format import statement #1464

merged 10 commits into from
May 27, 2020

Conversation

thinkerou
Copy link
Contributor

first part: the standard package
second part: third package
third part: k6 package

@thinkerou
Copy link
Contributor Author

have the follow error:

go version go1.14.3 linux/amd64
cmd/pause.go:29:2: cannot find package "github.com/loadimpack/k6/api/v1" in any of:
	/home/circleci/.go_workspace/src/github.com/loadimpact/k6/vendor/github.com/loadimpack/k6/api/v1 (vendor tree)
	/usr/local/go/src/github.com/loadimpack/k6/api/v1 (from $GOROOT)
	/home/circleci/.go_workspace/src/github.com/loadimpack/k6/api/v1 (from $GOPATH)

@thinkerou
Copy link
Contributor Author

I only change order: https://github.com/loadimpact/k6/pull/1464/files#diff-f2ba53414ba64f2e71d42ad483572e4cR29

but have the follow error:

go version go1.14.3 linux/amd64
cmd/pause.go:29:2: cannot find package "github.com/loadimpack/k6/api/v1" in any of:
	/home/circleci/.go_workspace/src/github.com/loadimpact/k6/vendor/github.com/loadimpack/k6/api/v1 (vendor tree)
	/usr/local/go/src/github.com/loadimpack/k6/api/v1 (from $GOROOT)
	/home/circleci/.go_workspace/src/github.com/loadimpack/k6/api/v1 (from $GOPATH)

Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a typo, loadimpack should be loadimpact ...

@thinkerou
Copy link
Contributor Author

You have a typo, loadimpack should be loadimpact ...

@na-- oh...fixed, thanks!

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020

Codecov Report

Merging #1464 into new-schedulers will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           new-schedulers    #1464      +/-   ##
==================================================
- Coverage           76.74%   76.71%   -0.04%     
==================================================
  Files                 163      163              
  Lines               12996    12996              
==================================================
- Hits                 9974     9970       -4     
- Misses               2511     2515       +4     
  Partials              511      511              
Impacted Files Coverage Δ
api/v1/client/client.go 0.00% <ø> (ø)
api/v1/group.go 90.90% <ø> (ø)
api/v1/group_routes.go 66.66% <ø> (ø)
api/v1/metric.go 100.00% <ø> (ø)
api/v1/metric_routes.go 82.35% <ø> (ø)
api/v1/setup_teardown_routes.go 63.82% <ø> (ø)
api/v1/status.go 100.00% <ø> (ø)
cmd/cloud.go 9.02% <ø> (ø)
cmd/collectors.go 0.00% <ø> (ø)
cmd/common.go 50.00% <ø> (ø)
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a1546...775b919. Read the comment docs.

Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rice-box.go files are go:generated files, so you shouldn't change them manually. Please revert those, the other changes seem fine.

@thinkerou
Copy link
Contributor Author

The rice-box.go files are go:generated files, so you shouldn't change them manually. Please revert those, the other changes seem fine.

@na-- thanks! suggest to add DO NOT EDIT sign like elements_gen.go and file name add _gen.go postfix.

@na--
Copy link
Member

na-- commented May 27, 2020

Feel free to use this PR to rename them (and adjust the go:generate commands) to have _gen.go in the name 😉

@thinkerou
Copy link
Contributor Author

Feel free to use this PR to rename them (and adjust the go:generate commands) to have _gen.go in the name 😉

OK, I will reopen one pr to solve it -- rice_box_gen.go

@na-- na-- merged commit 91b8023 into grafana:new-schedulers May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants