Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make certain that even sneakily open can't be used outside the init c… #1475

Merged
merged 5 commits into from
May 29, 2020

Conversation

mstoykov
Copy link
Collaborator

…ontext

@mstoykov mstoykov requested review from imiric and na-- May 29, 2020 09:33
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2020

Codecov Report

Merging #1475 into new-schedulers will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           new-schedulers    #1475      +/-   ##
==================================================
+ Coverage           76.69%   76.71%   +0.01%     
==================================================
  Files                 163      163              
  Lines               13011    13010       -1     
==================================================
+ Hits                 9979     9980       +1     
+ Misses               2520     2518       -2     
  Partials              512      512              
Impacted Files Coverage Δ
js/initcontext.go 90.42% <100.00%> (+0.20%) ⬆️
js/runner.go 82.50% <100.00%> (-0.19%) ⬇️
lib/executor/variable_looping_vus.go 94.46% <0.00%> (-0.80%) ⬇️
lib/executor/vu_handle.go 97.01% <0.00%> (+2.98%) ⬆️
lib/helpers.go 100.00% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83d0fcf...b7cc8fd. Read the comment docs.

js/initcontext.go Outdated Show resolved Hide resolved
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general

@mstoykov mstoykov merged commit c1687e0 into new-schedulers May 29, 2020
@mstoykov mstoykov deleted the fixOpenBeingUsableOutsideOfTheInitContext branch May 29, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants