Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/block hostname #1666

Merged
merged 18 commits into from
Oct 16, 2020
Merged

Feature/block hostname #1666

merged 18 commits into from
Oct 16, 2020

Conversation

mstoykov
Copy link
Collaborator

@mstoykov mstoykov commented Oct 9, 2020

This supersedes #1532

@mstoykov mstoykov added this to the v0.29.0 milestone Oct 9, 2020
@mstoykov mstoykov requested review from imiric and na-- October 9, 2020 13:26
@codecov-io
Copy link

codecov-io commented Oct 9, 2020

Codecov Report

Merging #1666 into master will decrease coverage by 0.14%.
The diff coverage is 70.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1666      +/-   ##
==========================================
- Coverage   72.19%   72.05%   -0.15%     
==========================================
  Files         166      167       +1     
  Lines       12787    12876      +89     
==========================================
+ Hits         9232     9278      +46     
- Misses       3005     3035      +30     
- Partials      550      563      +13     
Flag Coverage Δ
#ubuntu 72.03% <70.11%> (?)
#windows 70.60% <70.11%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/options.go 61.43% <33.33%> (-1.76%) ⬇️
lib/types/hostnametrie.go 68.75% <68.75%> (ø)
js/runner.go 82.33% <100.00%> (+0.06%) ⬆️
lib/netext/dialer.go 95.91% <100.00%> (+0.17%) ⬆️
lib/netext/httpext/error_codes.go 98.48% <100.00%> (+0.04%) ⬆️
lib/options.go 83.41% <100.00%> (+0.15%) ⬆️
stats/statsd/collector.go 65.21% <0.00%> (-34.79%) ⬇️
stats/datadog/collector.go 74.19% <0.00%> (-25.81%) ⬇️
lib/executor/vu_handle.go 93.33% <0.00%> (-1.91%) ⬇️
stats/cloud/collector.go 79.81% <0.00%> (-0.64%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef717e1...8321e9b. Read the comment docs.

lib/types/hostnametrie.go Show resolved Hide resolved
lib/types/hostnametrie_test.go Outdated Show resolved Hide resolved
lib/netext/dialer.go Outdated Show resolved Hide resolved
lib/netext/dialer.go Outdated Show resolved Hide resolved
lib/types/hostnametrie.go Outdated Show resolved Hide resolved
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't spot anything that @imiric hadn't already commented on, so LGTM besides these comments

lib/types/hostnametrie.go Outdated Show resolved Hide resolved
Co-authored-by: Ivan Mirić <ivan@loadimpact.com>
Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mstoykov mstoykov requested a review from na-- October 15, 2020 08:19
@mstoykov mstoykov merged commit f65ba5b into master Oct 16, 2020
@mstoykov mstoykov deleted the feature/block-hostname branch October 16, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants