Print errors stopping the execution to the stderr #1690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken after the adding of the loki logger output and should be better fixed, but a better fix will required either rewrite of the cmd package or more global variables, so this is preferable for now.
Codecov Report
@@ Coverage Diff @@
## master #1690 +/- ##
==========================================
- Coverage 72.26% 72.23% -0.03%
==========================================
Files 175 175
Lines 13443 13447 +4
==========================================
Hits 9714 9714
- Misses 3121 3125 +4
Partials 608 608
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
imiric
reviewed
Oct 27, 2020
imiric
approved these changes
Oct 27, 2020
|
Get superseded by #1694 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken after the adding of the loki logger output and should be
better fixed, but a better fix will required either rewrite of the cmd
package or more global variables, so this is preferable for now.