Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't exit on 'k6 cloud -q' just don't print progress #1702

Merged
merged 1 commit into from Oct 30, 2020

Conversation

mstoykov
Copy link
Collaborator

fixes #1371

@mstoykov mstoykov added this to the v0.29.0 milestone Oct 30, 2020
@mstoykov mstoykov requested review from imiric and na-- October 30, 2020 16:12
@codecov-io
Copy link

codecov-io commented Oct 30, 2020

Codecov Report

Merging #1702 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1702      +/-   ##
==========================================
- Coverage   72.34%   72.34%   -0.01%     
==========================================
  Files         176      176              
  Lines       13535    13533       -2     
==========================================
- Hits         9792     9790       -2     
  Misses       3130     3130              
  Partials      613      613              
Flag Coverage Δ
#ubuntu 72.33% <ø> (+0.02%) ⬆️
#windows 70.87% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/cloud.go 6.85% <ø> (+0.07%) ⬆️
core/engine.go 90.95% <0.00%> (-2.02%) ⬇️
lib/testutils/minirunner/minirunner.go 86.04% <0.00%> (+4.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb884a...ff337ea. Read the comment docs.

@mstoykov mstoykov merged commit 92b8776 into master Oct 30, 2020
@mstoykov mstoykov deleted the dontExitK6CloudWhenQuiet branch October 30, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k6 cloud --quiet exits immediately after the test run starts
3 participants