Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrival rate fixes #2038

Merged
merged 3 commits into from
May 25, 2021
Merged

Arrival rate fixes #2038

merged 3 commits into from
May 25, 2021

Commits on May 21, 2021

  1. Fix race in ramping arrival rate 

    originally discussed in this comment
#1957 (comment)
    @mstoykov
    mstoykov committed May 21, 2021
    Configuration menu
    Copy the full SHA
    0edccb0 View commit details
    Browse the repository at this point in the history

  2. constant-arrival-rate: Avoid to spawn a new goroutine for every itera… 

    …tion

Reusing the work done in #1957
    @mstoykov
    mstoykov committed May 21, 2021
    Configuration menu
    Copy the full SHA
    db89d21 View commit details
    Browse the repository at this point in the history

  3. When adding a VU to the pool wait for it the goroutine to starting 

    This helps with the fact that there is no gurantee currently that just
because we have added 100 VUs any of them had actually started wait for
an iteration.

This likely has some downside in creating more channels when adding VUs
back and forth but it should be minimal compared to the amount of work
needed to call a JS function.

This additionally could've meant that for high rate runs it was possible
for not all VUs to be available leading to k6 not actually being able to
run iterations at the given rate even though it should've been able if
all the VUs had actually started.
    @mstoykov
    mstoykov committed May 21, 2021
    Configuration menu
    Copy the full SHA
    5df0e6b View commit details
    Browse the repository at this point in the history