Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes remaining things Github forms #2179

Merged
merged 2 commits into from Oct 13, 2021
Merged

Fixes remaining things Github forms #2179

merged 2 commits into from Oct 13, 2021

Conversation

divshacker
Copy link
Contributor

Committing remaining changes based on suggestions given in #2174

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2021

Codecov Report

Merging #2179 (06fe656) into master (42f2e60) will decrease coverage by 0.03%.
The diff coverage is 71.42%.

❗ Current head 06fe656 differs from pull request most recent head 6740fd1. Consider uploading reports for the commit 6740fd1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2179      +/-   ##
==========================================
- Coverage   72.71%   72.68%   -0.04%     
==========================================
  Files         184      182       -2     
  Lines       14571    14572       +1     
==========================================
- Hits        10596    10592       -4     
- Misses       3333     3335       +2     
- Partials      642      645       +3     
Flag Coverage Δ
ubuntu 72.68% <71.42%> (+0.03%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/login_cloud.go 0.00% <0.00%> (ø)
cmd/login_influxdb.go 0.00% <0.00%> (ø)
cmd/ui.go 20.61% <0.00%> (ø)
js/compiler/compiler.go 55.00% <ø> (ø)
lib/execution_segment.go 92.73% <ø> (ø)
lib/executor/ramping_vus.go 94.66% <ø> (ø)
lib/metrics/metrics.go 100.00% <ø> (ø)
ui/form_fields.go 45.71% <0.00%> (ø)
js/modules/k6/ws/ws.go 83.51% <100.00%> (+0.35%) ⬆️
output/csv/config.go 74.00% <100.00%> (+4.23%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c826104...6740fd1. Read the comment docs.

Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@divshacker
Copy link
Contributor Author

Don't know why test got failed XD

Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The test failed because some of our tests are a bit flaky (#2144). I made a note there and re-ran them.

@na-- na-- merged commit da43ba7 into grafana:master Oct 13, 2021
@mstoykov mstoykov added this to the v0.35.0 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants