Drop map structure #2223
Merged
Drop map structure #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As well as the whole lib.NullDecoder as it's only used for this
na--
reviewed
Nov 3, 2021
na--
reviewed
Nov 3, 2021
the last use case for sourcemaps in the compiler isn't supported currently either way and can just as well be done with json.Unmarshal as it's done in a WIP PR
mstoykov
force-pushed
the
dropMapStructure
branch
from
af560a0
to
938d8ff
Compare
na--
approved these changes
Nov 4, 2021
inancgumus
approved these changes
Nov 4, 2021
|
this btw drops around 120kb from the final binary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.