js/ws: modulev2 migration #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to fix |
imiric
previously approved these changes
Nov 10, 2021
Migrated the WebSocket module to the ModuleV2 API https://pkg.go.dev/go.k6.io/k6@v0.34.1/js/modules#IsModuleV2
codebien
force-pushed
the
ws-modulev2
branch
from
8f00859
to
a29cf43
Compare
na--
requested review from
oleiade and
mstoykov
and removed request for
inancgumus
mstoykov
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
js/wsmodule migration implementing the ModuleV2 API.The
Connectmethod requires some refactoring to remove the linter issues (too many statements and cyclomatic complexity). I tried to fix it directly here but from my exploration, it requires too many changes compared to this, so I would prefer to have a separated PR for refactoring instead unique one.