Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/1443 remove the JS runtime from threshold calculations #2251

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Fix/1443 remove the JS runtime from threshold calculations #2251

merged 2 commits into from
Jan 12, 2022

Commits on Jan 11, 2022

  1. Add threshold parsing functions to the stats package 

    In this commit we use the parser combinator library
introduced in the previous commit to build a threshold
expression parser. We match the existing supported
expression format, without any modifications or
additions.
    @oleiade
    oleiade committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    dd2edd7 View commit details
    Browse the repository at this point in the history

  2. Remove the JS runtime from threshold calculations 

    In this commit we replace the previously existing
thresholds condition evaluation, which was depending
on Goja's Runtime, with a new pure-Go one.

Thresholds are now parsed, and evaluated in o, and
no JS rutimes are involved in the process anymore. It
is built upong the thresholds parser, and parser
combinators library introduced in previous commits.
    @oleiade
    oleiade committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    81cccd9 View commit details
    Browse the repository at this point in the history