Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install from source instructions #2359

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Conversation

Karitham
Copy link
Contributor

@Karitham Karitham commented Jan 27, 2022

From go 1.18 onwards (https://tip.golang.org/doc/go1.18#tools), to install a package from source, we MUST use go install.
Since the command is already available before (from 1.16 onwards) and it's the recommended way to install a package, why not use it?

From go 1.18 onwards (https://tip.golang.org/doc/go1.18#tools), to install a package from source, we have to use `go install`.
Since the command is already available before (from 1.16 onwards) and it's the recommended way to install a package, why not use it?
@CLAassistant
Copy link

CLAassistant commented Jan 27, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2022

Codecov Report

Merging #2359 (dedf44a) into master (42f2e60) will increase coverage by 1.89%.
The diff coverage is 79.70%.

❗ Current head dedf44a differs from pull request most recent head 97f1c73. Consider uploading reports for the commit 97f1c73 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2359      +/-   ##
==========================================
+ Coverage   72.71%   74.61%   +1.89%     
==========================================
  Files         184      188       +4     
  Lines       14571    15124     +553     
==========================================
+ Hits        10596    11285     +689     
+ Misses       3333     3154     -179     
- Partials      642      685      +43     
Flag Coverage Δ
ubuntu 74.47% <79.63%> (+1.82%) ⬆️
windows 74.19% <79.70%> (+1.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/v1/client/client.go 0.00% <0.00%> (ø)
api/v1/client/metrics.go 0.00% <0.00%> (ø)
api/v1/client/status.go 0.00% <0.00%> (ø)
api/v1/group.go 31.25% <ø> (-57.82%) ⬇️
api/v1/metric.go 68.00% <ø> (-32.00%) ⬇️
api/v1/routes.go 55.31% <ø> (ø)
api/v1/status.go 75.00% <ø> (-25.00%) ⬇️
cmd/archive.go 11.76% <0.00%> (+0.65%) ⬆️
cmd/cloud.go 4.76% <0.00%> (+0.04%) ⬆️
cmd/inspect.go 0.00% <0.00%> (ø)
... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb70bc6...97f1c73. Read the comment docs.

Copy link
Collaborator

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mstoykov mstoykov merged commit 6634620 into grafana:master Jan 28, 2022
@mstoykov mstoykov added this to the v0.37.0 milestone Jan 28, 2022
@Karitham Karitham deleted the patch-1 branch January 28, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants