Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golangci version #2923

Merged
merged 6 commits into from Feb 21, 2023
Merged

Bump golangci version #2923

merged 6 commits into from Feb 21, 2023

Conversation

codebien
Copy link
Collaborator

@codebien codebien commented Feb 21, 2023

The diff for the disabled linters:

-dupword: checks for duplicate words in the source code
-ginkgolinter: enforces standards of using ginkgo and gomega
-gocheckcompilerdirectives: Checks that go compiler directive comments (//go:) are valid.
-interfacebloat: A linter that checks the number of methods inside an interface.
-loggercheck (logrlint): Checks key valur pairs for common logger libraries (kitlog,klog,logr,zap). 
-musttag: enforce field tags in (un)marshaled structs
-reassign: Checks that package variables are not reassigned
-testableexamples: linter checks if examples are testable (have an expected output)
-usestdlibvars: A linter that detect the possibility to use variables/constants from the Go standard library.

From the previous list this PR enables the following new linters:

  • gocheckcompilerdirectives
  • reassign
  • usestdlibvars

It resolves points 2-3 from #2715

@codebien codebien added this to the v0.44.0 milestone Feb 21, 2023
@codebien codebien self-assigned this Feb 21, 2023
@codebien codebien marked this pull request as ready for review February 21, 2023 14:49
@codebien codebien requested review from mstoykov and removed request for oleiade February 21, 2023 14:50
olegbespalov
olegbespalov previously approved these changes Feb 21, 2023
mstoykov
mstoykov previously approved these changes Feb 21, 2023
@codebien codebien dismissed stale reviews from mstoykov and olegbespalov via 253d4b0 February 21, 2023 15:11
@codebien
Copy link
Collaborator Author

Sorry, I forgot to update the CI job.

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2023

Codecov Report

Merging #2923 (90b9784) into master (27b8e7e) will increase coverage by 0.02%.
The diff coverage is 83.33%.

❗ Current head 90b9784 differs from pull request most recent head 253d4b0. Consider uploading reports for the commit 253d4b0 to get more accurate results

@@            Coverage Diff             @@
##           master    #2923      +/-   ##
==========================================
+ Coverage   76.89%   76.92%   +0.02%     
==========================================
  Files         225      225              
  Lines       16874    16874              
==========================================
+ Hits        12976    12980       +4     
+ Misses       3065     3063       -2     
+ Partials      833      831       -2     
Flag Coverage Δ
ubuntu 76.84% <83.33%> (+0.02%) ⬆️
windows 76.70% <83.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/ui_unix.go 100.00% <ø> (ø)
loader/loader.go 82.87% <50.00%> (ø)
cloudapi/api.go 52.08% <100.00%> (ø)
converter/har/converter.go 61.17% <100.00%> (ø)
output/cloud/metrics_client.go 84.61% <100.00%> (ø)
lib/executor/vu_handle.go 93.45% <0.00%> (-1.87%) ⬇️
js/initcontext.go 88.18% <0.00%> (+1.57%) ⬆️
metrics/metric_type.go 82.45% <0.00%> (+3.50%) ⬆️
api/v1/metric.go 63.63% <0.00%> (+9.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@codebien codebien merged commit eb2a54d into master Feb 21, 2023
@codebien codebien deleted the bump-lint-version branch February 21, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants