Drop a sample that uses a removed REST API #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sample is 6 years old and uses a version of k6 cloud (at the time Load Impact) that predates k6 itself and has been removed for several years now. The sample while more on the complex side is not very useful as it can't be run. There are also now a lot more example in the wild of complex scripts then 6 years ago.
|
This is the remaining places where "Load Impact" referenced apart from #2942 and release notes which I don't think we should update. |
Codecov Report
@@ Coverage Diff @@
## master #2943 +/- ##
==========================================
- Coverage 76.96% 76.94% -0.02%
==========================================
Files 225 225
Lines 16893 16893
==========================================
- Hits 13001 12998 -3
- Misses 3061 3064 +3
Partials 831 831
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
na--
approved these changes
Feb 27, 2023
imiric
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sample is 6 years old and uses a version of k6 cloud (at the time Load Impact) that predates k6 itself and has been removed for several years now.
The sample while more on the complex side is not very useful as it can't be run.
There are also now a lot more example in the wild of complex scripts then 6 years ago.