Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor k6 js module tests to have one helper function #2946

Merged
merged 1 commit into from Mar 7, 2023
Merged

Refactor k6 js module tests to have one helper function #2946

merged 1 commit into from Mar 7, 2023

Conversation

mstoykov
Copy link
Collaborator

No description provided.

@mstoykov mstoykov added this to the v0.44.0 milestone Feb 28, 2023
@github-actions github-actions bot requested review from imiric and na-- February 28, 2023 12:07
@mstoykov mstoykov mentioned this pull request Feb 28, 2023
Merged
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023 •
edited

Codecov Report

Merging #2946 (e97ddc6) into master (0b1fe61) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head e97ddc6 differs from pull request most recent head 8d044a6. Consider uploading reports for the commit 8d044a6 to get more accurate results

@@            Coverage Diff             @@
##           master    #2946      +/-   ##
==========================================
- Coverage   76.96%   76.91%   -0.05%     
==========================================
  Files         226      226              
  Lines       16910    16910              
==========================================
- Hits        13014    13007       -7     
- Misses       3065     3070       +5     
- Partials      831      833       +2
Flag Coverage Δ
ubuntu 76.85% <ø> (ø)
windows 76.73% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/v1/metric.go 54.54% <0.00%> (-22.73%) ⬇️
metrics/value_type.go 62.50% <0.00%> (-6.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

imiric
imiric previously approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mstoykov mstoykov mentioned this pull request Feb 28, 2023
Merged
na--
na-- previously approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Base automatically changed from fixCheckAtEndOfIteration to master March 6, 2023 10:20
@mstoykov mstoykov dismissed stale reviews from na-- and imiric via 8d044a6 March 6, 2023 10:23
@mstoykov mstoykov requested review from imiric and na-- March 6, 2023 10:25
@mstoykov
Copy link
Collaborator Author

mstoykov commented Mar 6, 2023

Sorry squashing the original PR required me to rebase this ... without actually having to do anything manually ;(

@mstoykov mstoykov merged commit 6e767d7 into master Mar 7, 2023
@mstoykov mstoykov deleted the k6TestRefactor branch March 7, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imiric imiric imiric approved these changes

@na-- na-- na-- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.44.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mstoykov @codecov-commenter @imiric @na--