Fix panic handling and add a new exit code and a test for panics #2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imiric
previously approved these changes
Mar 31, 2023
| rootCmd.cmd.AddCommand(&cobra.Command{ | ||
| Use: "panic", | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| panic("oh no, oh no, oh no,no,no,no,no") |
codebien
previously approved these changes
Mar 31, 2023
na--
force-pushed
the
fix-panic-handling
branch
from
1dde205
to
cf4fd49
Compare
Because we started calling os.Exit() in a defer statement, we circumvented the regular handling of panics that bubble up to the top by the Go runtime. I could have removed the os.Exit() call from the defer, but handling panics ourselves in this way allows us to handle them exactly how we want, assign them their own unique exit code, and test the whole thing with an e2e test.
na--
force-pushed
the
fix-panic-handling
branch
from
cf4fd49
to
e4265bb
Compare
Codecov Report
@@ Coverage Diff @@
## master #2997 +/- ##
==========================================
+ Coverage 76.90% 76.93% +0.03%
==========================================
Files 228 228
Lines 17043 17050 +7
==========================================
+ Hits 13107 13118 +11
+ Misses 3090 3086 -4
Partials 846 846
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
codebien
approved these changes
Mar 31, 2023
imiric
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2833 we started calling
os.Exit()in adeferstatement, so we inadvertently circumvented the regular handling of panics that bubble up to the top by the Go runtime.I could have removed the
os.Exit()call from thedefer, but I think this is better. Handling panics ourselves in this way is explicit, simpler to understand, and it allows us to handle them exactly how we want - including assigning them their own unique exit code, and test the whole thing with an e2e test.