Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update goja #3002

Merged
merged 1 commit into from Apr 5, 2023
Merged

Update goja #3002

merged 1 commit into from Apr 5, 2023

Conversation

mstoykov
Copy link
Collaborator

@mstoykov mstoykov commented Apr 3, 2023

@github-actions github-actions bot requested review from codebien and imiric April 3, 2023 08:42
- cpu profiler see #3001
- improved source location of dotted assignment
Copy link
Collaborator

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did you check the pprof dep impact on the binary size?

@mstoykov
Copy link
Collaborator Author

mstoykov commented Apr 3, 2023

, did you check the pprof dep impact on the binary size?

36kb on my machine with CGO_ENABLED=0 which is how we compile either way

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Merging #3002 (f80089e) into master (988f2f6) will not change coverage.
The diff coverage is n/a.

❗ Current head f80089e differs from pull request most recent head 05bbfb5. Consider uploading reports for the commit 05bbfb5 to get more accurate results

@@           Coverage Diff           @@
##           master    #3002   +/-   ##
=======================================
  Coverage   76.99%   76.99%           
=======================================
  Files         228      228           
  Lines       17050    17050           
=======================================
  Hits        13128    13128           
  Misses       3079     3079           
  Partials      843      843           
Flag Coverage Δ
ubuntu 76.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mstoykov mstoykov merged commit b4d4f77 into master Apr 5, 2023
21 checks passed
@mstoykov mstoykov deleted the updateGoja branch April 5, 2023 15:04
@olegbespalov olegbespalov added this to the v0.44.0 milestone Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants