Update to xk6-websockets v0.2.0 #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebien
reviewed
Apr 5, 2023
| # github.com/grafana/xk6-websockets v0.1.6 | ||
| ## explicit; go 1.17 | ||
| # github.com/grafana/xk6-websockets v0.2.0 | ||
| ## explicit; go 1.18 |
There was a problem hiding this comment.
I think we could align with k6
There was a problem hiding this comment.
I am not even certain why we have bumpbed to 1.19 - I don't think we use anything from it.
The only reason why I did it for xk6-websockets was to stop having to give -compat 1.17, so I don't really care. But will prefer to not have to try to keep this number in sync, given that I don't see a reason to do it.
There was a problem hiding this comment.
I bumped go.mod to go 1.19 to align it with the officially supported Go versions, and to also resolve some issues with go mod tidy not working well when it was go 1.17.
na--
approved these changes
Apr 5, 2023
codebien
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "fixes" a potential lock up, but that was already fixed in k6 in #3004.
So this is mostly a somewhat of refactor and simplying PR.
As well as make
pingthrow an exception if used with a closed connection.