Add issue auto-assignment and improve PR reviewer assignment #3045
Conversation
|
This PR doesn't actually use the new PR auto-assignment, since |
Codecov Report
@@ Coverage Diff @@
## master #3045 +/- ##
==========================================
+ Coverage 77.01% 77.02% +0.01%
==========================================
Files 229 229
Lines 17065 17065
==========================================
+ Hits 13143 13145 +2
+ Misses 3080 3079 -1
+ Partials 842 841 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| - uses: kentaro-m/auto-assign-action@6d966a1f3bd73adfe44dd19dc42cc5845e39ebd3 # v1.2.4 | ||
| - uses: actions/github-script@v6 |
There was a problem hiding this comment.
Nice that this is a relatively trivial dependency to remove 👍
.github/workflows/pr-auto-assign.yml
Outdated
| github.rest.pulls.requestReviewers({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| pull_number: context.payload.pull_request.number, | ||
| reviewers: assigneesWithoutAuthor.sort(() => 0.5 - Math.random()).slice(0, reviewerCount), |
There was a problem hiding this comment.
Do you know if this will only do the assignment if the PR is marked as "ready for review", i.e. not for draft PRs? If not, we should ignore the assignment for draft PRs.
Ah, the on configuration above should handle it, right?
on:
pull_request_target:
types: [opened, ready_for_review, reopened]
Though does opened include draft PRs? 🤔
There was a problem hiding this comment.
Hmm I am not sure, https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request doesn't seem to document this explicitly. I suggest we try it like this and adjust if needed.
My guess is that just the ready_for_review event won't trigger if I open a new non-draft PR, so we need all 3. The actual solution might be to add some if JavaScript check in the job body to short-circuit it and return early if the PR is in a draft state 🤔
Co-authored-by: Ivan Mirić <ivan.miric@grafana.com>
Co-authored-by: Ivan Mirić <ivan.miric@grafana.com>
I've tested some of the things in a throwaway repo, but this might require a few subsequent PRs to fix any bugs...