Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k6/metrics: Warn on metric names not compatible with Prometheus #3066

Merged
merged 1 commit into from May 15, 2023
Merged

k6/metrics: Warn on metric names not compatible with Prometheus #3066

merged 1 commit into from May 15, 2023

Commits on May 15, 2023

  1. k6/metrics: Warn on metric names not compatible with Prometheus 

    This adds a warning for custom metrics that are not Prometheus
compatible.

The warning is in the js/bundle mostly for convenience.

It is a place we already have a registry and a logger and we go through
only once.

As this is temporary warning until we enforce stricter metric names
I don't think it is good idea to refactor the registry to support this
for a little while.

Updates #3065
    @mstoykov
    mstoykov committed May 15, 2023
    Configuration menu
    Copy the full SHA
    1d9c60c View commit details
    Browse the repository at this point in the history