Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downloading golangci-lint config file for PRs from forks #3086

Merged
merged 1 commit into from May 23, 2023

Conversation

imiric
Copy link
Contributor

@imiric imiric commented May 22, 2023

The lint action previously didn't work for PRs submitted from forks. See #3078 and the job error:

Downloading https://raw.githubusercontent.com/grafana/k6/patch-1/.golangci.yml...
curl: (22) The requested URL returned error: 404

@imiric imiric requested a review from na-- May 22, 2023 13:54
@imiric imiric force-pushed the fix/ci-lint-fork branch 2 times, most recently from 85f2b24 to bb365ec Compare May 22, 2023 14:02
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2023

Codecov Report

Merging #3086 (973ad8f) into master (f43cc83) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 973ad8f differs from pull request most recent head 937996e. Consider uploading reports for the commit 937996e to get more accurate results

@@            Coverage Diff             @@
##           master    #3086      +/-   ##
==========================================
+ Coverage   76.77%   76.79%   +0.01%     
==========================================
  Files         230      230              
  Lines       17179    17179              
==========================================
+ Hits        13190    13192       +2     
+ Misses       3142     3140       -2     
  Partials      847      847              
Flag Coverage Δ
ubuntu 76.79% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@imiric imiric force-pushed the fix/ci-lint-fork branch 4 times, most recently from 937996e to b80839a Compare May 22, 2023 15:43
@imiric imiric marked this pull request as ready for review May 22, 2023 16:01
@imiric imiric requested a review from oleiade May 22, 2023 16:09
@imiric imiric merged commit 477bc02 into grafana:master May 23, 2023
21 of 22 checks passed
@imiric imiric deleted the fix/ci-lint-fork branch May 23, 2023 14:48
@mstoykov mstoykov added this to the v0.45.0 milestone Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants