Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example in run command #3094

Merged
merged 1 commit into from May 26, 2023
Merged

Fix example in run command #3094

merged 1 commit into from May 26, 2023

Conversation

rockwotj
Copy link
Contributor

The second stage was missing the number of VU, and actually running that command caused complaints.

The second stage was missing the number of VU, and actually running that command caused complaints.
@CLAassistant
Copy link

CLAassistant commented May 25, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching it! This example has been wrong since the beginning of k6 in 2017 😅

@codecov-commenter
Copy link

Codecov Report

Merging #3094 (e50d5ef) into master (5738ce0) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head e50d5ef differs from pull request most recent head af5e697. Consider uploading reports for the commit af5e697 to get more accurate results

@@            Coverage Diff             @@
##           master    #3094      +/-   ##
==========================================
- Coverage   75.29%   75.28%   -0.02%     
==========================================
  Files         233      233              
  Lines       17607    17607              
==========================================
- Hits        13258    13255       -3     
- Misses       3497     3500       +3     
  Partials      852      852              
Flag Coverage Δ
ubuntu 75.28% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/run.go 72.76% <100.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Collaborator

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! 👍

@imiric imiric merged commit 622e0a1 into grafana:master May 26, 2023
22 checks passed
@olegbespalov olegbespalov added this to the v0.45.0 milestone May 26, 2023
@rockwotj rockwotj deleted the patch-1 branch May 26, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants