Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output/cloudv2: Use a static remote service url #3125

Merged
merged 1 commit into from Jun 21, 2023

Conversation

codebien
Copy link
Collaborator

It moves the sets of the test run id and the relative URL generation from per request to once per client.

@codebien codebien added this to the v0.46.0 milestone Jun 15, 2023
@codebien codebien self-assigned this Jun 15, 2023
@github-actions github-actions bot requested review from imiric and oleiade June 15, 2023 08:19
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

Merging #3125 (44b9843) into master (629d0fd) will decrease coverage by 0.12%.
The diff coverage is 71.42%.

❗ Current head 44b9843 differs from pull request most recent head 9239f74. Consider uploading reports for the commit 9239f74 to get more accurate results

@@            Coverage Diff             @@
##           master    #3125      +/-   ##
==========================================
- Coverage   73.90%   73.79%   -0.12%     
==========================================
  Files         243      241       -2     
  Lines       18489    18483       -6     
==========================================
- Hits        13664    13639      -25     
- Misses       3958     3972      +14     
- Partials      867      872       +5     
Flag Coverage Δ
ubuntu 73.79% <71.42%> (-0.03%) ⬇️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
output/cloud/expv2/metrics_client.go 59.37% <50.00%> (-1.24%) ⬇️
output/cloud/expv2/flush.go 84.61% <100.00%> (ø)
output/cloud/expv2/output.go 86.84% <100.00%> (ø)

... and 12 files with indirect coverage changes

@codebien codebien mentioned this pull request Jun 15, 2023
@codebien codebien force-pushed the cloud-v2-retries branch 2 times, most recently from 79be0d6 to e1b7419 Compare June 15, 2023 10:37
Base automatically changed from cloud-v2-retries to master June 15, 2023 11:38
@imiric
Copy link
Contributor

imiric commented Jun 15, 2023

@codebien I'm waiting for this PR to also be rebased and the conflicts resolved before reviewing it.

imiric
imiric previously approved these changes Jun 19, 2023
output/cloud/expv2/metrics_client.go Outdated Show resolved Hide resolved
@codebien codebien requested review from olegbespalov and removed request for oleiade June 19, 2023 09:42
olegbespalov
olegbespalov previously approved these changes Jun 19, 2023
@codebien codebien merged commit 9fdd569 into master Jun 21, 2023
21 checks passed
@codebien codebien deleted the cloudv2-use-static-url branch June 21, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants