Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a promises package with a New helper function #3176

Merged
merged 7 commits into from
Jul 10, 2023
Merged

Add a promises package with a New helper function #3176

merged 7 commits into from
Jul 10, 2023

Commits on Jul 7, 2023

  1. Add a promises package with a MakeHandledPromise helper. 

    This helper function makes it convenient to create a promise in the
context of  k6 module/extension Go code.
    @oleiade
    oleiade committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    606d2ee View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com>
    @oleiade @mstoykov
    oleiade and mstoykov committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    0fe402c View commit details
    Browse the repository at this point in the history

  3. Address issues introduced by accepted suggestions

    @oleiade
    oleiade committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    084c1d3 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Update js/promises/promises.go 

    Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
    @oleiade @codebien
    oleiade and codebien committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    5063abe View commit details
    Browse the repository at this point in the history

  2. Update js/promises/promises.go 

    Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
    @oleiade @codebien
    oleiade and codebien committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    a555274 View commit details
    Browse the repository at this point in the history

  3. rename MakeHandledPromise to New

    @oleiade
    oleiade committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    3bba811 View commit details
    Browse the repository at this point in the history

  4. Update js/promises/promises.go 

    Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
    @oleiade @codebien
    oleiade and codebien committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    ebd3486 View commit details
    Browse the repository at this point in the history