k6 Insights (2/2): Integrate request metadata output to cloud output v1 #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blinkuu
force-pushed
the
integrate_insights_to_v1_output
branch
from
e5594bb
to
d7395ae
Compare
Codecov Report
@@ Coverage Diff @@
## master #3202 +/- ##
=======================================
Coverage 72.69% 72.70%
=======================================
Files 254 259 +5
Lines 19802 19864 +62
=======================================
+ Hits 14396 14442 +46
- Misses 4497 4519 +22
+ Partials 909 903 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
olegbespalov
changed the base branch from
master
to
refactor_request_metadata_output_to_separate_package
olegbespalov
requested review from
oleiade
and removed request for
mstoykov and
imiric
olegbespalov
requested changes
Jul 17, 2023
olegbespalov
previously approved these changes
Jul 19, 2023
oleiade
previously approved these changes
Jul 19, 2023
Base automatically changed from
refactor_request_metadata_output_to_separate_package
to
master
July 19, 2023 10:05
oleiade
dismissed stale reviews from olegbespalov and themself
The base branch was changed.
Blinkuu
force-pushed
the
integrate_insights_to_v1_output
branch
from
0844bcb
to
2a2f95c
Compare
olegbespalov
approved these changes
Jul 19, 2023
oleiade
approved these changes
Jul 19, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR incorporates the request metadata output into cloud output v1.
Why?
Due to cloud output v2 being at risk for v0.46.0, we decided to incorporate the new request metadata output into cloud output v1. This change is done to mitigate the risk of failing to deliver the new insights features.
Related PR(s)/Issue(s)
This PR is part of a PR chain. Previous PR - #3201.
Previous PRs: