-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable user headers in the reflect call in client.connect #3242
Conversation
…eflect command that comes after client.connect
Rao Li seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov Report
@@ Coverage Diff @@
## master #3242 +/- ##
==========================================
- Coverage 73.21% 73.16% -0.06%
==========================================
Files 259 257 -2
Lines 19899 19906 +7
==========================================
- Hits 14569 14564 -5
- Misses 4406 4412 +6
- Partials 924 930 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lirao,
thanks for your contribution. 🙏 Can you please sign the CLA so we can accept your contribution?
Hi, is it ok if someone on the k6 team make this change instead? I can't sign the CLA. |
Closing since I can't sign the CLA. Can someone else make this change instead? |
What?
Add a parameter
reflectMetadata
inclient.connect
to add user-provided headers in the reflect call.Why?
Some GRPC servers require a header to authenticate any call (including reflection). The invoke command covers this use case, but the reflect command that's bundled in the connect command does not, which leads to authentication errors.
Checklist
make ci-like-lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)
Closes #3241