Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Build multi platform images #3320

Merged
merged 1 commit into from Sep 12, 2023
Merged

docker: Build multi platform images #3320

merged 1 commit into from Sep 12, 2023

Conversation

codebien
Copy link
Collaborator

@codebien codebien commented Sep 4, 2023

What?

Support docker builds for arm64

Why?

Users are requesting it more and more times

Related PR(s)/Issue(s)

Closes #3301

@codebien codebien self-assigned this Sep 4, 2023
@codebien codebien added this to the v0.47.0 milestone Sep 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (fd6551d) 73.21% compared to head (3e1bab4) 73.20%.
Report is 1 commits behind head on master.

❗ Current head 3e1bab4 differs from pull request most recent head dde958d. Consider uploading reports for the commit dde958d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3320      +/-   ##
==========================================
- Coverage   73.21%   73.20%   -0.02%     
==========================================
  Files         258      258              
  Lines       19895    19895              
==========================================
- Hits        14566    14564       -2     
- Misses       4404     4406       +2     
  Partials      925      925              
Flag Coverage Δ
ubuntu 73.13% <ø> (-0.02%) ⬇️
windows 73.05% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codebien codebien marked this pull request as ready for review September 5, 2023 07:59
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
@codebien
Copy link
Collaborator Author

codebien commented Sep 5, 2023

@mstoykov @olegbespalov Just for sharing other plans. I would like to apply in a dedicated PR after this how we are doing the push. We now are processing sequentially by registry. I would prefer if we do it instead by kind of build. I take the assumption that the risk of failure is higher between the different versions than the same build pushed across different registries.
So, if one build fails, all the steps before are already fine across all the registries, so we could skip them and rebuild only the failed+missing steps with the guarantee that the same version is the same code across different registries.

Essentially, I'm suggesting doing the equivalent solution: https://docs.docker.com/build/ci/github-actions/push-multi-registries/

WDYT?

@codebien codebien force-pushed the build-docker-arm64 branch 2 times, most recently from 89cb8de to dde958d Compare September 5, 2023 13:40
@codebien codebien merged commit 53b6f22 into master Sep 12, 2023
21 checks passed
@codebien codebien deleted the build-docker-arm64 branch September 12, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publish arm64 images to Docker hub
4 participants