Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the deprecated convert command #3365

Merged
merged 1 commit into from Oct 12, 2023
Merged

Drop the deprecated convert command #3365

merged 1 commit into from Oct 12, 2023

Conversation

codebien
Copy link
Collaborator

@codebien codebien commented Oct 3, 2023

What?

It drops the har converter as we decided in #1124, and it is following the deprecation process started by #2714.

https://github.com/grafana/har-to-k6 is the alternative

@codebien codebien added this to the v0.48.0 milestone Oct 3, 2023
@codebien codebien self-assigned this Oct 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8457c91) 72.95% compared to head (a56a0ae) 73.05%.

❗ Current head a56a0ae differs from pull request most recent head 1870bb1. Consider uploading reports for the commit 1870bb1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3365      +/-   ##
==========================================
+ Coverage   72.95%   73.05%   +0.09%     
==========================================
  Files         261      256       -5     
  Lines       20018    19642     -376     
==========================================
- Hits        14605    14349     -256     
+ Misses       4486     4406      -80     
+ Partials      927      887      -40     
Flag Coverage Δ
ubuntu 73.05% <100.00%> (+0.15%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/root.go 94.26% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codebien codebien requested review from a team, oleiade and olegbespalov and removed request for a team October 3, 2023 16:03
@codebien codebien marked this pull request as ready for review October 3, 2023 16:03
@codebien codebien merged commit d91cecb into master Oct 12, 2023
22 checks passed
@codebien codebien deleted the remove-convert-cmd branch October 12, 2023 07:57
@olegbespalov olegbespalov added the breaking change for PRs that need to be mentioned in the breaking changes section of the release notes label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change for PRs that need to be mentioned in the breaking changes section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants