Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS tests on the CI #3367

Closed
wants to merge 4 commits into from
Closed

MacOS tests on the CI #3367

wants to merge 4 commits into from

Conversation

codebien
Copy link
Collaborator

@codebien codebien commented Oct 3, 2023

What?

Why?

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make ci-like-lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (001aff5) 72.47% compared to head (9a39458) 72.96%.
Report is 1 commits behind head on master.

❗ Current head 9a39458 differs from pull request most recent head 96e7370. Consider uploading reports for the commit 96e7370 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3367      +/-   ##
==========================================
+ Coverage   72.47%   72.96%   +0.49%     
==========================================
  Files         274      261      -13     
  Lines       20837    20018     -819     
==========================================
- Hits        15101    14607     -494     
+ Misses       4769     4484     -285     
+ Partials      967      927      -40     
Flag Coverage Δ
ubuntu 72.91% <ø> (+0.44%) ⬆️
windows 72.80% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codebien
Copy link
Collaborator Author

Closing in favor of #3528

@codebien codebien closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants