Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output/csv: Revert the JSON names of the config #3395

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

codebien
Copy link
Collaborator

@codebien codebien commented Oct 13, 2023

What?

Restore the output/csv config to use the snake_case for the JSON names #3390 (comment). It keeps the changes related to the CLI flags.

Why?

The breaking change would introduce some risks that we have to analyze better.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make ci-like-lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

#3390

@codebien codebien added this to the v0.48.0 milestone Oct 13, 2023
@codebien codebien self-assigned this Oct 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e8886ac) 73.13% compared to head (0b6890e) 73.13%.

❗ Current head 0b6890e differs from pull request most recent head 18e1b01. Consider uploading reports for the commit 18e1b01 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3395   +/-   ##
=======================================
  Coverage   73.13%   73.13%           
=======================================
  Files         258      258           
  Lines       19642    19642           
=======================================
  Hits        14365    14365           
  Misses       4395     4395           
  Partials      882      882           
Flag Coverage Δ
ubuntu 73.06% <ø> (-0.02%) ⬇️
windows 72.96% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
output/csv/config.go 74.50% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codebien codebien marked this pull request as ready for review October 16, 2023 11:01
@codebien codebien merged commit 990d925 into master Oct 16, 2023
22 checks passed
@codebien codebien deleted the revert-3390-no-csv-snakecase branch October 16, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants