Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update goja #3397

Merged
merged 1 commit into from Oct 16, 2023
Merged

Update goja #3397

merged 1 commit into from Oct 16, 2023

Conversation

olegbespalov
Copy link
Collaborator

@olegbespalov olegbespalov commented Oct 16, 2023

What?

Update goja to the latest version since it fixes the bug, that could lead to panic.

Why?

Panics are bad.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make ci-like-lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

dop251/goja#540

@olegbespalov olegbespalov added the dependencies Pull requests that update a dependency file label Oct 16, 2023
@olegbespalov olegbespalov added this to the v0.48.0 milestone Oct 16, 2023
@olegbespalov olegbespalov self-assigned this Oct 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e8886ac) 73.13% compared to head (e128a06) 73.12%.

❗ Current head e128a06 differs from pull request most recent head 9c6f280. Consider uploading reports for the commit 9c6f280 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3397      +/-   ##
==========================================
- Coverage   73.13%   73.12%   -0.02%     
==========================================
  Files         258      258              
  Lines       19642    19642              
==========================================
- Hits        14365    14363       -2     
- Misses       4395     4397       +2     
  Partials      882      882              
Flag Coverage Δ
ubuntu 73.06% <ø> (-0.02%) ⬇️
windows 72.95% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olegbespalov olegbespalov merged commit 43f10a0 into master Oct 16, 2023
23 checks passed
@olegbespalov olegbespalov deleted the chore/goja-update branch October 16, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants