Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump goja version #3427

Merged
merged 1 commit into from Oct 27, 2023
Merged

Bump goja version #3427

merged 1 commit into from Oct 27, 2023

Conversation

codebien
Copy link
Collaborator

@codebien codebien commented Oct 27, 2023

It fixes an issue about dumping the correct stack trace when an error is re-thrown. dop251/goja@b396bb4

@codebien codebien added this to the v0.48.0 milestone Oct 27, 2023
@codebien codebien self-assigned this Oct 27, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4049795) 73.33% compared to head (c6b6dc3) 73.33%.

❗ Current head c6b6dc3 differs from pull request most recent head 96030d0. Consider uploading reports for the commit 96030d0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3427   +/-   ##
=======================================
  Coverage   73.33%   73.33%           
=======================================
  Files         258      258           
  Lines       19645    19645           
=======================================
+ Hits        14406    14407    +1     
+ Misses       4354     4353    -1     
  Partials      885      885           
Flag Coverage Δ
ubuntu 73.27% <ø> (+<0.01%) ⬆️
windows 73.18% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codebien codebien marked this pull request as ready for review October 27, 2023 13:19
@codebien codebien requested review from mstoykov and removed request for olegbespalov October 27, 2023 13:20
@codebien codebien merged commit 92e3aca into master Oct 27, 2023
24 checks passed
@codebien codebien deleted the bump-goja-stacktrace-fix branch October 27, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants