Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erroring on modules with no scheme #3449

Closed
wants to merge 1 commit into from

Conversation

olegbespalov
Copy link
Collaborator

@olegbespalov olegbespalov commented Nov 9, 2023

What?

As was planned in the #3287 we removed the support of adding https:// for the module resolution.

Why?

#3287

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Closes #3287

@olegbespalov olegbespalov added the breaking change for PRs that need to be mentioned in the breaking changes section of the release notes label Nov 9, 2023
@olegbespalov olegbespalov self-assigned this Nov 9, 2023
@olegbespalov olegbespalov force-pushed the chore/3287-deprecate-prepanding branch from 5d7a4c5 to 72ca5be Compare November 9, 2023 14:02
@olegbespalov olegbespalov added this to the v0.48.0 milestone Nov 9, 2023
@olegbespalov
Copy link
Collaborator Author

I am closing in favor of the solution with more code cleaning involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change for PRs that need to be mentioned in the breaking changes section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove trying to load remote modules by prepending https://
1 participant