Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golangci-lint to v1.55.2 #3469

Merged
merged 1 commit into from Nov 24, 2023
Merged

Bump golangci-lint to v1.55.2 #3469

merged 1 commit into from Nov 24, 2023

Conversation

olegbespalov
Copy link
Collaborator

@olegbespalov olegbespalov commented Nov 24, 2023

What?

Bump golangci-lint to the latest version. It contains the fixes for the gosec linter, which won't cause false-positive errors.

Why?

Otherwise, we must make inline exceptions in the projects using the same linter ruleset.

For cases like:

const distributionKey = "LOREM_IPSUM"

it could scream that this is hardcoded credentials.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@olegbespalov olegbespalov self-assigned this Nov 24, 2023
@olegbespalov olegbespalov requested review from codebien and removed request for mstoykov November 24, 2023 08:18
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (38f273d) 73.21% compared to head (d7ca0fc) 73.19%.

❗ Current head d7ca0fc differs from pull request most recent head 238f020. Consider uploading reports for the commit 238f020 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3469      +/-   ##
==========================================
- Coverage   73.21%   73.19%   -0.02%     
==========================================
  Files         267      267              
  Lines       20083    20083              
==========================================
- Hits        14704    14700       -4     
- Misses       4465     4469       +4     
  Partials      914      914              
Flag Coverage Δ
ubuntu 73.14% <ø> (-0.02%) ⬇️
windows 73.05% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codebien codebien added this to the v0.48.0 milestone Nov 24, 2023
@olegbespalov olegbespalov merged commit e603a49 into master Nov 24, 2023
22 checks passed
@olegbespalov olegbespalov deleted the chore/update-golang-ci branch November 24, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants