Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes linter issues in testutils package #3480

Merged
merged 2 commits into from Dec 7, 2023

Conversation

olegbespalov
Copy link
Collaborator

@olegbespalov olegbespalov commented Nov 30, 2023

What?

Fixes linter issues of the testutils packages.

Why?

As we agreed we'd like to reach ~0 issues in master branch.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Part of #769

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (856a767) 73.22% compared to head (9c5145b) 73.20%.

❗ Current head 9c5145b differs from pull request most recent head 34cab33. Consider uploading reports for the commit 34cab33 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3480      +/-   ##
==========================================
- Coverage   73.22%   73.20%   -0.03%     
==========================================
  Files         267      267              
  Lines       20083    20083              
==========================================
- Hits        14706    14701       -5     
- Misses       4463     4468       +5     
  Partials      914      914              
Flag Coverage Δ
ubuntu 73.14% <100.00%> (-0.03%) ⬇️
windows 73.06% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mstoykov
mstoykov previously approved these changes Nov 30, 2023
@olegbespalov olegbespalov changed the title Fixes linter issues in httpmultibin package Fixes linter issues in testutils package Nov 30, 2023
@olegbespalov olegbespalov merged commit c6e4ce4 into master Dec 7, 2023
21 checks passed
@olegbespalov olegbespalov deleted the chore/httpmultibin-linter-fixes branch December 7, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants