Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint issues in output/cloud/* #3483

Merged
merged 1 commit into from Dec 7, 2023
Merged

Fix lint issues in output/cloud/* #3483

merged 1 commit into from Dec 7, 2023

Conversation

mstoykov
Copy link
Collaborator

@mstoykov mstoykov commented Dec 1, 2023

works on #769

@mstoykov mstoykov added this to the v0.49.0 milestone Dec 1, 2023
@mstoykov mstoykov self-assigned this Dec 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (856a767) 73.22% compared to head (6f6d91b) 73.21%.

❗ Current head 6f6d91b differs from pull request most recent head f35ea7c. Consider uploading reports for the commit f35ea7c to get more accurate results

Files Patch % Lines
output/cloud/output.go 0.00% 1 Missing and 1 partial ⚠️
output/cloud/v1/data.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3483      +/-   ##
==========================================
- Coverage   73.22%   73.21%   -0.01%     
==========================================
  Files         267      267              
  Lines       20083    20084       +1     
==========================================
- Hits        14706    14705       -1     
- Misses       4463     4465       +2     
  Partials      914      914              
Flag Coverage Δ
ubuntu 73.16% <62.50%> (-0.01%) ⬇️
windows 73.07% <62.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mstoykov mstoykov changed the title Fix lint issues in output/cloud Fix lint issues in output/cloud/* Dec 1, 2023
@mstoykov mstoykov merged commit 6889b38 into master Dec 7, 2023
22 checks passed
@mstoykov mstoykov deleted the lintFixOutputCloud branch December 7, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants