Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js/path_resolution_test: more ESM related tests #3678

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

mstoykov
Copy link
Collaborator

@mstoykov mstoykov commented Apr 8, 2024

What?

Add more tests for paths and ESM

Why?

Found corner cases that ESM make harder to handle and/or break.

Other PRs will handle fixing and warning them.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added the tests label Apr 8, 2024
@mstoykov mstoykov added this to the v0.51.0 milestone Apr 8, 2024
@mstoykov mstoykov requested a review from a team as a code owner April 8, 2024 08:17
@mstoykov mstoykov requested review from codebien and joanlopez and removed request for a team April 8, 2024 08:17
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.23%. Comparing base (f2006f6) to head (908d37d).
Report is 2 commits behind head on master.

❗ Current head 908d37d differs from pull request most recent head 2e4ddb4. Consider uploading reports for the commit 2e4ddb4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3678      +/-   ##
==========================================
- Coverage   73.31%   73.23%   -0.08%     
==========================================
  Files         278      276       -2     
  Lines       20327    20324       -3     
==========================================
- Hits        14903    14885      -18     
- Misses       4480     4489       +9     
- Partials      944      950       +6     
Flag Coverage Δ
macos ?
ubuntu 73.23% <100.00%> (-0.03%) ⬇️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mstoykov mstoykov merged commit a62140c into master Apr 8, 2024
24 of 25 checks passed
@mstoykov mstoykov deleted the moreRequereTests branch April 8, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants