Fix line numbers in case of commonJS file with no sourcemap #3687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
requested review from
oleiade and
olegbespalov
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3687 +/- ##
==========================================
- Coverage 73.33% 73.33% -0.01%
==========================================
Files 278 278
Lines 20329 20332 +3
==========================================
+ Hits 14908 14910 +2
- Misses 4477 4478 +1
Partials 944 944
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
olegbespalov
previously approved these changes
Apr 12, 2024
Previously if someone imports or runs a commonJS file (one that won't need to go through babel) we still need to wrap it in some code to run it. But we don't have a sourcemap to update, unless it already had one(internal babel adds it). This leads to all lines being off by 1. This is fixed by updating the sourcemap in the other case. Unfortunately short of generating an "identity" sourcemap and then shifting it by 1 with adding `;` to the first mapping, this can't be done. The sourcemap implementation specifically wants to find each mapping, so unless it can do that it will not do anything. The remaining hack (adjusting any available sourcemap) still stands as it also fixes the columns on the *first* line of the file. As well as actually being better.
oleiade
approved these changes
Apr 12, 2024
olegbespalov
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix line numbers in case of commonJS file with no sourcemap:
Why?
Previously if someone imports or runs a commonJS file (one that won't
need to go through babel) we still need to wrap it in some code to run
it. But we don't have a sourcemap to update, unless it already had
one(internal babel adds it). This leads to all lines being off by 1.
This is fixed by updating the sourcemap in the other case.
Unfortunately short of generating an "identity" sourcemap and then
shifting it by 1 with adding
;to the first mapping, this can't bedone.
The sourcemap implementation specifically wants to find each mapping, so
unless it can do that it will not do anything.
The remaining hack (adjusting any available sourcemap) still stands as
it also fixes the columns on the first line of the file. As well as
actually being better.
Also found that while fixing linter issue I broke the tc39 error generation :(.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)