feat: promote env variable to ProfilingEnabled option #3692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bablzz
requested review from
mstoykov and
oleiade
and removed request for
a team
|
|
mstoykov
reviewed
Apr 19, 2024
Comment on lines
+180
to
+182
| if _, ok := env["K6_PROFILING_ENABLED"]; ok { | ||
| result.ProfilingEnabled = true | ||
| } |
There was a problem hiding this comment.
Can you please add a test for this in the configuraiton consolidation tests as was previously requested in the issue.
There was a problem hiding this comment.
Yes and thsi can aso be set by cli flag
There was a problem hiding this comment.
I have seen a code - I have to check --profiling-enabled and K6_PROFILING_ENABLED together, right?
mstoykov
approved these changes
Apr 24, 2024
oleiade
approved these changes
Apr 24, 2024
it's a pleasure for me! |
mstoykov
added
the
documentation-needed
|
I can add documentation if nobody disagrees. |
|
Thank you @Bablzz 🙇 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add env option K6_PROFILING_ENABLED to enable it in k6
Why?
Fix issue #3670
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)