ci: temporary disable running tests on macOS #3695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegbespalov
requested review from
mstoykov and
joanlopez
and removed request for
a team
joanlopez
approved these changes
Apr 19, 2024
Yeah, let's collect some data about which are the most noisy ones, and take a look at them, when possible. |
mstoykov
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR temporarily disables running the tests in CI on the Mac OS platform because it's too flaky right now.
If this PR is approved after the merge, I'll open a separate issue for investigation and bring Mac OS tests back.
Why?
Unfortunately, Mac OS tests failed for many runs. Constantly failing tests are destructive for the project since people tend to trust test runs less, and we could miss something essential.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)