Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump google.golang.org/grpc to v1.63.2 from v1.63.0 #3705

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

mstoykov
Copy link
Collaborator

@mstoykov mstoykov commented Apr 22, 2024

What?

Bumpt grpc dep

Why?

Mostly to revert a change where they deprecated an API.

The API will be depracated in a later version again, but we can skip seeing the warning and decide to move of it in #3699

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v0.51.0 milestone Apr 22, 2024
@mstoykov mstoykov requested a review from a team as a code owner April 22, 2024 13:08
@mstoykov mstoykov requested review from codebien and joanlopez and removed request for a team April 22, 2024 13:08
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.29%. Comparing base (0e48fa2) to head (023182c).

❗ Current head 023182c differs from pull request most recent head 14d9400. Consider uploading reports for the commit 14d9400 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3705      +/-   ##
==========================================
- Coverage   73.30%   73.29%   -0.01%     
==========================================
  Files         278      278              
  Lines       20389    20389              
==========================================
- Hits        14947    14945       -2     
- Misses       4492     4494       +2     
  Partials      950      950              
Flag Coverage Δ
ubuntu 73.24% <ø> (+<0.01%) ⬆️
windows 73.14% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mstoykov mstoykov merged commit dc39ec7 into master Apr 23, 2024
21 checks passed
@mstoykov mstoykov deleted the bumpgRPCDep branch April 23, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants